Changeset 3174

Timestamp:

2007-07-30 02:49:21 (1 year ago)

Author:

conrad

Message:

Refactor oggz_get_serialno_new() to avoid using library rand()/random().
Instead, it generates a pseudorandom serialno on request, ensuring that the
number selected is not -1 or the serialno of an existing logical bitstream.
NB. This inlines a simple linear congruential generator to avoid problems
of portability of rand() vs. the POSIX random()/initstate()/getstate(), and
in the case of rand() in order to avoid interfering with the random number
sequence. Adapated from a patch by Erik de Castro Lopo, July 2007.

Files:

• liboggz/trunk/configure.ac (modified) (1 diff)
• liboggz/trunk/src/liboggz/oggz.c (modified) (1 diff)
• liboggz/trunk/src/liboggz/oggz_compat.h (modified) (1 diff)

liboggz/trunk/configure.ac

@@ -37 +37 @@
-# Checks for library functions.
-AC_FUNC_REALLOC
- random
+
-
-# Check for pkg-config

liboggz/trunk/src/liboggz/oggz.c

@@ -440 +440 @@
-}
-
+/* Generate a pseudorandom serialno on request, ensuring that the number
+ * selected is not -1 or the serialno of an existing logical bitstream.
+ * NB. This inlines a simple linear congruential generator to avoid problems
+ * of portability of rand() vs. the POSIX random()/initstate()/getstate(), and
+ * in the case of rand() in order to avoid interfering with the random number
+ * sequence.
+ * Adapated from a patch by Erik de Castro Lopo, July 2007.
+ */
-long
-oggz_serialno_new (OGGZ * oggz)
-{
-
+
+
+
+
-
-  do {
-
-
+
+
+
-
-  return serialno;

liboggz/trunk/src/liboggz/oggz_compat.h

@@ -33 +33 @@
-#include "config.h"
-
-#ifdef HAVE_RANDOM
-#  define oggz_random random
-#else
-#  define oggz_random rand
-#endif
-
-#ifndef WIN32
-#  define oggz_stat_regular(mode) (S_ISREG((mode)) || S_ISLNK((mode)))