Ticket #416 (closed defect: fixed)

Opened 3 months ago

Last modified 2 months ago

oggz-chop writes wrong granulerate in fisbone

Reported by: j Assigned to: conrad
Priority: normal Milestone:
Component: liboggz Version:
Severity: major Keywords:
Cc:

Description

right now oggz-chop always writes 1:1 as granulerate. this is wrong. attached is a patch that gets that info just before writing the fisbone, at that point liboggz is initialized with the formation needed.

Attachments

oggz_get_granulerate_later.patch (1.4 kB) - added by j on 2008-08-12 03:58:29.

Change History

2008-08-12 03:58:29 changed by j

  • attachment oggz_get_granulerate_later.patch added.

2008-08-12 03:59:37 changed by j

here the output of oggz-info -a for input, trunk and patched versions 

Filename: input.ogv
Content-Duration: 00:02:00.000
Content-Length: 7.925 MB
Content-Bitrate-Average: 553.987 kbps

Skeleton: serialno 1868229106
	4 packets in 3 pages, 1.3 packets/page, 27.508% Ogg overhead
	Content-Length: 309 bytes
	Content-Bitrate-Average: 20 bps
	Presentation-Time: 0.000
	Basetime: 0.000
	Page-Length-Maximum: 189 bytes
	Page-Length-StdDev: 81 bytes
	Packet-Length-Maximum: 80 bytes
	Packet-Length-StdDev: 38 bytes
	Skeleton version: 3.0

Theora: serialno 1540971931
	3001 packets in 1621 pages, 1.9 packets/page, 1.042% Ogg overhead
	Content-Length: 6.607 MB
	Content-Bitrate-Average: 461.897 kbps
	Video-Framerate: 25.000 fps
	Video-Width: 512
	Video-Height: 288
	Page-Length-Maximum: 4.294 kB
	Page-Length-StdDev: 157 bytes
	Packet-Length-Maximum: 25.004 kB
	Packet-Length-StdDev: 2.448 kB

	Extra information from Ogg Skeleton track:
	Number of header packets: 3
	Granule rate: 25.00
	Granule shift: 6
	Start granule: 0|0
	Preroll: 0
	Message Header Fields:
	 Content-Type: video/theora	 	 

Vorbis: serialno 1142956214
	14711 packets in 339 pages, 43.4 packets/page, 1.729% Ogg overhead
	Content-Length: 1.317 MB
	Content-Bitrate-Average: 92.069 kbps
	Audio-Samplerate: 48000 Hz
	Audio-Channels: 2
	Page-Length-Maximum: 4.312 kB
	Page-Length-StdDev: 545 bytes
	Packet-Length-Maximum: 3.742 kB
	Packet-Length-StdDev: 78 bytes

	Extra information from Ogg Skeleton track:
	Number of header packets: 3
	Granule rate: 48000.00
	Granule shift: 0
	Start granule: 0
	Preroll: 2
	Message Header Fields:
	 Content-Type: audio/vorbis	 	 
------------------------------------------------------------
Filename: trunk.ogv
Content-Duration: 00:00:00.128
Content-Length: 111.964 kB
Content-Bitrate-Average: 7.166 Mbps

Skeleton: serialno 1868229106
	4 packets in 4 pages, 1.0 packets/page, 25.455% Ogg overhead
	Content-Length: 440 bytes
	Content-Bitrate-Average: 27.500 kbps
	Presentation-Time: 35.000
	Basetime: 0.000
	Page-Length-Maximum: 188 bytes
	Page-Length-StdDev: 67 bytes
	Packet-Length-Maximum: 160 bytes
	Packet-Length-StdDev: 67 bytes
	Skeleton version: 3.0

Theora: serialno 1540971931
	68 packets in 26 pages, 2.6 packets/page, 1.082% Ogg overhead
	Content-Length: 103.514 kB
	Content-Bitrate-Average: 6.625 Mbps
	Video-Framerate: 25.000 fps
	Video-Width: 512
	Video-Height: 288
	Page-Length-Maximum: 4.282 kB
	Page-Length-StdDev: 876 bytes
	Packet-Length-Maximum: 21.763 kB
	Packet-Length-StdDev: 2.901 kB

	Extra information from Ogg Skeleton track:
	Number of header packets: 3
	Granule rate: 1.00
	Granule shift: 0
	Start granule: 749|61
	Preroll: 0
	Message Header Fields:
	 Content-Type: video/theora	 	 fisbone

Vorbis: serialno 1142956214
	36 packets in 3 pages, 12.0 packets/page, 1.607% Ogg overhead
	Content-Length: 8.021 kB
	Content-Bitrate-Average: 513.312 kbps
	Audio-Samplerate: 48000 Hz
	Audio-Channels: 2
	Page-Length-Maximum: 4.102 kB
	Page-Length-StdDev: 2.269 kB
	Packet-Length-Maximum: 3.742 kB
	Packet-Length-StdDev: 622 bytes

	Extra information from Ogg Skeleton track:
	Number of header packets: 3
	Granule rate: 1.00
	Granule shift: 0
	Start granule: 1666240
	Preroll: 0
	Message Header Fields:
------------------------------------------------------------
Filename: patched.ogv
Content-Duration: 00:00:00.128
Content-Length: 111.964 kB
Content-Bitrate-Average: 7.166 Mbps

Skeleton: serialno 1868229106
	4 packets in 4 pages, 1.0 packets/page, 25.455% Ogg overhead
	Content-Length: 440 bytes
	Content-Bitrate-Average: 27.500 kbps
	Presentation-Time: 35.000
	Basetime: 0.000
	Page-Length-Maximum: 188 bytes
	Page-Length-StdDev: 67 bytes
	Packet-Length-Maximum: 160 bytes
	Packet-Length-StdDev: 67 bytes
	Skeleton version: 3.0

Theora: serialno 1540971931
	68 packets in 26 pages, 2.6 packets/page, 1.082% Ogg overhead
	Content-Length: 103.514 kB
	Content-Bitrate-Average: 6.625 Mbps
	Video-Framerate: 25.000 fps
	Video-Width: 512
	Video-Height: 288
	Page-Length-Maximum: 4.282 kB
	Page-Length-StdDev: 876 bytes
	Packet-Length-Maximum: 21.763 kB
	Packet-Length-StdDev: 2.901 kB

	Extra information from Ogg Skeleton track:
	Number of header packets: 3
	Granule rate: 25.00
	Granule shift: 6
	Start granule: 749|61
	Preroll: 0
	Message Header Fields:
	 Content-Type: video/theora	 	 fisbone

Vorbis: serialno 1142956214
	36 packets in 3 pages, 12.0 packets/page, 1.607% Ogg overhead
	Content-Length: 8.021 kB
	Content-Bitrate-Average: 513.312 kbps
	Audio-Samplerate: 48000 Hz
	Audio-Channels: 2
	Page-Length-Maximum: 4.102 kB
	Page-Length-StdDev: 2.269 kB
	Packet-Length-Maximum: 3.742 kB
	Packet-Length-StdDev: 622 bytes

	Extra information from Ogg Skeleton track:
	Number of header packets: 3
	Granule rate: 48000.00
	Granule shift: 0
	Start granule: 1666240
	Preroll: 0
	Message Header Fields:

2008-09-17 00:25:47 changed by conrad

Should be fixed in changeset:3718, which corrects the library behaviour:

  • Add internal oggz_auto_read_bos_page()
  • Use oggz_auto_read_bos_page() when a new bos page is encountered, before calling the user's page reader callback
  • Correct the granulerate denominator reported by oggz_get_granulerate, removing the internal OGGZ_AUTO_MULT scaling

2008-09-20 04:46:30 changed by j

  • status changed from new to closed.
  • resolution set to fixed.

looks fine here